[libvirt] [PATCH] qemu: Fix assignment of the default spicevmc channel name

Ján Tomko jtomko at redhat.com
Tue Jun 30 08:58:05 UTC 2015


On Tue, Jun 30, 2015 at 10:31:51AM +0200, Jiri Denemark wrote:
> Make sure we only assign the default spicevmc channel name to spicevmc
> virtio channels. Caused by commits 3269ee65 and 1133ee2b, which moved
> the assignment from XML parsing code to QEMU but failed to keep the
> logic.
> 
> https://bugzilla.redhat.com/show_bug.cgi?id=1179680
> 

Also fixes https://bugzilla.redhat.com/show_bug.cgi?id=1226854

> Signed-off-by: Jiri Denemark <jdenemar at redhat.com>
> ---
>  src/qemu/qemu_command.c                            |  4 ++-
>  .../qemuxml2argv-channel-virtio-default.args       | 16 ++++++++++
>  .../qemuxml2argv-channel-virtio-default.xml        | 36 ++++++++++++++++++++++
>  tests/qemuxml2argvtest.c                           |  3 ++
>  4 files changed, 58 insertions(+), 1 deletion(-)
>  create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-channel-virtio-default.args
>  create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-channel-virtio-default.xml
> 

ACK

Jan
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20150630/062ed175/attachment-0001.sig>


More information about the libvir-list mailing list