[libvirt] [PATCH 02/35] conf: Refactor emulatorpin handling

Martin Kletzander mkletzan at redhat.com
Mon Jun 1 09:47:26 UTC 2015


On Fri, May 29, 2015 at 03:33:23PM +0200, Peter Krempa wrote:
>Store the emulator pinning cpu mask as a pure virBitmap rather than the
>virDomainPinDef since it stores only the bitmap and refactor
>qemuDomainPinEmulator to do the same operations in a much saner way.
>
>As a side effect virDomainEmulatorPinAdd and virDomainEmulatorPinDel can
>be removed since they don't add any value.
>---
> src/conf/domain_conf.c   | 66 +++------------------------------
> src/conf/domain_conf.h   |  8 +---
> src/libvirt_private.syms |  2 -
> src/qemu/qemu_cgroup.c   |  2 +-
> src/qemu/qemu_driver.c   | 96 +++++++++++++-----------------------------------
> src/qemu/qemu_process.c  |  2 +-
> 6 files changed, 34 insertions(+), 142 deletions(-)
>

ACK, nice cleanup.  I wonder why we complicated this in the first place...
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20150601/e4c2094f/attachment-0001.sig>


More information about the libvir-list mailing list