[libvirt] [PATCH 08/35] libxl: Reuse virBitmapToData in libxlDomainSetVcpuAffinities

[Ján Tomko]

On Fri, May 29, 2015 at 03:33:29PM +0200, Peter Krempa wrote:
> ---
>  src/libxl/libxl_domain.c | 21 ++++-----------------
>  1 file changed, 4 insertions(+), 17 deletions(-)
> 

ACK

> diff --git a/src/libxl/libxl_domain.c b/src/libxl/libxl_domain.c
> index c7f0ed9..89782c3 100644
> --- a/src/libxl/libxl_domain.c
> +++ b/src/libxl/libxl_domain.c
> @@ -797,34 +797,21 @@ libxlDomainSetVcpuAffinities(libxlDriverPrivatePtr driver, virDomainObjPtr vm)
>      virDomainDefPtr def = vm->def;
>      libxl_bitmap map;
>      virBitmapPtr cpumask = NULL;
> -    uint8_t *cpumap = NULL;
>      virNodeInfo nodeinfo;
> -    size_t cpumaplen;
>      int vcpu;
> -    size_t i;
>      int ret = -1;
> 
>      if (libxlDriverNodeGetInfo(driver, &nodeinfo) < 0)
>          goto cleanup;

This call can also be removed - nodeinfo is unused after this patch.

> 
> -    cpumaplen = VIR_CPU_MAPLEN(VIR_NODEINFO_MAXCPUS(nodeinfo));
> -
>      for (vcpu = 0; vcpu < def->cputune.nvcpupin; ++vcpu) {
>          if (vcpu != def->cputune.vcpupin[vcpu]->id)
>              continue;

Jan
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20150602/b8ed534f/attachment-0001.sig>