[libvirt] [PATCH 2/2] qemu: fix a document issue as we support host-passthrough with features

Luyao Huang lhuang at redhat.com
Wed Jun 17 14:22:45 UTC 2015


>From the documentation :"With this mode, the CPU visible to
the guest should be exactly the same as the host CPU even in
the aspects that libvirt does not understand."

So this place document need fix.

Signed-off-by: Luyao Huang <lhuang at redhat.com>
---
 src/qemu/qemu_process.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/src/qemu/qemu_process.c b/src/qemu/qemu_process.c
index 64ee049..3cd0ff4 100644
--- a/src/qemu/qemu_process.c
+++ b/src/qemu/qemu_process.c
@@ -4024,8 +4024,10 @@ qemuProcessVerifyGuestCPU(virQEMUDriverPtr driver,
     bool ret = false;
     size_t i;
 
-    /* no features are passed to QEMU with -cpu host
-     * so it makes no sense to verify them */
+    /* Although we allow set features with host-passthrough
+     * cpu mode, we allow user require/disable the feature
+     * that libvirt does not understand, so it makes no sense
+     * to verify them */
     if (def->cpu && def->cpu->mode == VIR_CPU_MODE_HOST_PASSTHROUGH)
         return true;
 
-- 
1.8.3.1




More information about the libvir-list mailing list