[libvirt] [PATCH] libxl: rework reference counting

Jim Fehlig jfehlig at suse.com
Wed Jun 17 17:28:15 UTC 2015


Anthony PERARD wrote:
> On Tue, Jun 16, 2015 at 10:53:15AM +0100, Anthony PERARD wrote:
>   
>> On Mon, Jun 15, 2015 at 08:36:47PM -0600, Jim Fehlig wrote:
>>     
>>> Similar to commit 540c339a for the QEMU driver, rework reference
>>> counting in the libxl driver to make it more deterministic and
>>> the code a bit cleaner.
>>>
>>> Signed-off-by: Jim Fehlig <jfehlig at suse.com>
>>> ---
>>>
>>> I've been testing this patch on and off for a few weeks now using
>>> libvirt-tck domain tests, local test scripts, and some manual tests
>>> for good measure.  I sent the patch to Anthony Perard (cc'd) nearly
>>> two weeks ago for testing in his OpenStack+Xen+libvirt CI loop,
>>> although I haven't received any feedback thus far.  Also included
>>> Martin in the cc since he encouraged this patch
>>>       
>> But I should be able to test the patch now.
>>     
>
> Hi, I gave this patch a try with OpenStack. I have applied the patch on top
> of libvirt 1.4.14 + (f86ae40 894d2ff 6dfec1e), which we are using for our CI.
>
> With the patch, libvirt works fine,

Thanks for testing it!

>  but I can still have the rare error
> "domain 205 device model: startup timed out".
>   

I would have been surprised if the patch fixed that mysterious problem.

Regards,
Jim




More information about the libvir-list mailing list