[libvirt] [PATCH 6/8] lib: setvcpus: Remove bogous flag check
Pavel Hrdina
phrdina at redhat.com
Fri Jun 19 08:13:32 UTC 2015
On Tue, Jun 16, 2015 at 07:43:18PM +0200, Peter Krempa wrote:
> Since VIR_DOMAIN_AFFECT_CURRENT is 0 the flag check does not make sense
> as masking @flags with 0 will always equal to false.
> ---
> src/libvirt-domain.c | 6 ------
> 1 file changed, 6 deletions(-)
>
> diff --git a/src/libvirt-domain.c b/src/libvirt-domain.c
> index 7e6d749..4d7b88a 100644
> --- a/src/libvirt-domain.c
> +++ b/src/libvirt-domain.c
> @@ -7267,12 +7267,6 @@ virDomainSetVcpusFlags(virDomainPtr domain, unsigned int nvcpus,
> VIR_DOMAIN_AFFECT_CONFIG,
> error);
>
> - VIR_EXCLUSIVE_FLAGS_GOTO(VIR_DOMAIN_AFFECT_CURRENT,
> - VIR_DOMAIN_AFFECT_LIVE,
> - error);
> - VIR_EXCLUSIVE_FLAGS_GOTO(VIR_DOMAIN_AFFECT_CURRENT,
> - VIR_DOMAIN_AFFECT_CONFIG,
> - error);
> VIR_EXCLUSIVE_FLAGS_GOTO(VIR_DOMAIN_VCPU_GUEST,
> VIR_DOMAIN_AFFECT_CONFIG,
> error);
> --
> 2.4.1
>
> --
> libvir-list mailing list
> libvir-list at redhat.com
> https://www.redhat.com/mailman/listinfo/libvir-list
ACK
Pavel
More information about the libvir-list
mailing list