[libvirt] [PATCH] qemu: blockcopy: Forbid using persistent bitmap granularity with raw vols

[Peter Krempa]

On Wed, Jun 24, 2015 at 16:48:16 +0800, Shanzhi Yu wrote:
> 
> 
> On 06/24/2015 03:11 PM, Peter Krempa wrote:
> > qemu returns error but only in the event after the block job actually
> > starts. Reject it upfront for a better error message.
> >
> > Instead of:
> > $ virsh blockcopy vm hdc /tmp/raw.img --granularity 4096 --verbose --wait
> > error: Block Copy unexpectedly failed
> >
> > You will now get:
> > $ virsh blockcopy vm hdc /tmp/raw.img --granularity 4096 --verbose --wait
> > error: unsupported configuration: granularity can't be used with target volume format
> 
> This can't avoid the cases that the source file has a raw format file as
> backing file.

AFAIK if the active image (top layer) is a qcow2, then the destination
is also created as a qcow2 and thus the persistent bitmap granularity
should work just fine.

Peter
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20150624/1e49852b/attachment-0001.sig>