[libvirt] [sandbox PATCH 04/10] Add disk support to the container builder

[Daniel P. Berrange]

On Fri, Jun 26, 2015 at 03:27:39PM +0200, Eren Yagdiran wrote:
> Use the new disk configuration in the container builder to provide disks in
> lxc containers sandboxes.
> ---
>  .../libvirt-sandbox-builder-container.c            | 33 +++++++++++++++++++++-
>  1 file changed, 32 insertions(+), 1 deletion(-)
ACK


> +    tmp = disks = gvir_sandbox_config_get_disks(config);
> +    while(tmp){

Nitpick, we'd usually have more whitespace  'while (tmp) {'

> +        GVirSandboxConfigDisk *dconfig = GVIR_SANDBOX_CONFIG_DISK(tmp->data);
> +
> +        if (GVIR_SANDBOX_IS_CONFIG_DISK(dconfig)){

And same here ')) {'

> +            gchar *device = g_strdup_printf("sd%c", (char)('a' + nVirtioDev++));
> +            disk = gvir_config_domain_disk_new();
> +            diskDriver = gvir_config_domain_disk_driver_new();
> +            gvir_config_domain_disk_set_type(disk,
> +                                             gvir_sandbox_config_disk_get_disk_type(dconfig));
> +            gvir_config_domain_disk_driver_set_format(diskDriver,
> +                                                      gvir_sandbox_config_disk_get_format(dconfig));
> +            gvir_config_domain_disk_set_source(disk,
> +                                               gvir_sandbox_config_disk_get_source(dconfig));
> +            gvir_config_domain_disk_set_target_dev(disk,device);
> +            gvir_config_domain_disk_set_driver(disk, diskDriver);
> +            gvir_config_domain_add_device(domain,
> +                                          GVIR_CONFIG_DOMAIN_DEVICE(disk));
> +            g_object_unref(disk);
> +        }
> +    tmp = tmp->next;

Indentation is too shallow

> +    }
> +

Regards,
Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|