[libvirt] [PATCH 0/2] Add configuration time check for invalid lun settings

[John Ferlan]

https://bugzilla.redhat.com/show_bug.cgi?id=1201143

Patch 1 is just a doc change - more a clarification regarding the 'exact'
configuration for https://bugzilla.redhat.com/show_bug.cgi?id=1228007

Patch 2 adds a configuration time check for the correct settings when
someone tries to configure a lun. This does to a degree duplicate some
checks in the run time check qemuCheckDiskConfig, but since allowing the
configuration was causing issues for at least virt-manager, it was
requested to do config time checks. The copious comment in the code
notes that the volume check is only partial since at the time of
post parse device callback, the Translation of source pool data to
disk data has not occurred, so the "best" that can be done is to check
if at least a non direct 'lun' volume type is being used (unless of
course we translated the source pool).

John Ferlan (2):
  docs: Clarification for when allowed to use 'lun' for "volume"
  conf: Validate disk lun using correct types

 docs/formatdomain.html.in |  3 ++-
 src/conf/domain_conf.c    | 22 ++++++++++++++++++++++
 tests/qemuxml2argvtest.c  |  2 +-
 3 files changed, 25 insertions(+), 2 deletions(-)

-- 
2.1.0