[libvirt] [PATCH] qemu: event: Fix retrieval of the "service" field from graphics events

[Daniel P. Berrange]

On Mon, Jun 29, 2015 at 03:35:05PM +0200, Jiri Denemark wrote:
> On Mon, Jun 29, 2015 at 15:17:50 +0200, Peter Krempa wrote:
> > On Mon, Jun 29, 2015 at 13:47:50 +0100, Daniel Berrange wrote:
> > > On Mon, Jun 29, 2015 at 02:42:50PM +0200, Peter Krempa wrote:
> > > > qemu's event has following format:
> > > > 
> > > > {
> > > >     "timestamp": {
> > > >         "seconds": 1435580974,
> > > >         "microseconds": 82226
> > > >     },
> > > >     "event": "SPICE_INITIALIZED",
> > > >     "data": {
> > > >         "server": {
> > > >             "auth": "none",
> > > >             "port": "5900",
> > > >             "family": "ipv4",
> > > >             "host": "127.0.0.1"
> > > >         },
> > > >         "client": {
> > > >             "port": "53224",
> > > >             "family": "ipv4",
> > > >             "channel-type": 3,
> > > >             "connection-id": 1113096064,
> > > >             "host": "127.0.0.1",
> > > >             "channel-id": 0,
> > > >             "tls": false
> > > >         }
> > > >     }
> > > > }
> > > > 
> > > > Our code tried to extract the "service" field but qemu reports it as
> > > > "port".
> > > 
> > > Hmm, that's somewhat odd - did you check back historical versions of
> > > QEMU where this event was first introduced to see if it has always
> > > had this name ? It smells like the kind of thing that could have been
> > > a regression at some point
> > 
> > Actually the regression would be on the VNC side, since VNC uses
> > "service" and the function that I've modified handles both. I failed to
> > notice that fact at first.
> 
> Heh, I was thinking "service" was an old downstream-only spelling of
> "port" and checked it wasn't the case. But I failed to notice the same
> handler is used for VNC too...

I've confirmed all the way back to 0.14.0 QEMU VNC and SPICE have used
different names service vs port respectively.

Regards,
Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|