[libvirt] [libvirt-glib PATCHv2 4/5] gobject: Add wrapper for virNetworkDHCPLease

[Christophe Fergeau]

Hey,

Looks good to me, I'd name the type GVirNetworkDhcpLease rather than
GVirNetworkDHCPLease, this is consistent with
GVirConfigCapabilitiesCpuModel (and not CPUModel).

Maybe more descriptive doc for some of the fields (client id, iaid, ...)
could be useful? Or are they just obvious for someone familiar with
dhcp?


On Mon, Jun 29, 2015 at 03:08:54PM +0100, Zeeshan Ali (Khattak) wrote:
> diff --git a/libvirt-gobject/libvirt-gobject-network-dhcp-lease.c b/libvirt-gobject/libvirt-gobject-network-dhcp-lease.c
> new file mode 100644
> index 0000000..57ccf0d
> --- /dev/null
> +++ b/libvirt-gobject/libvirt-gobject-network-dhcp-lease.c
> @@ -0,0 +1,252 @@
> +/*
> + * libvirt-gobject-network-dhcp-lease.h: libvirt glib integration

This is the .c file, not the .h file.


Christophe
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20150630/641ebe22/attachment-0001.sig>