[libvirt] [PATCH] storage: sheepdog: Avoid skipping variable initialization

Peter Krempa pkrempa at redhat.com
Mon Mar 2 09:12:06 UTC 2015


Commit 155ca616eb231181f6978efc9e3a1eb0eb60af8a added a error message
that skips initialization of the 'cmd' variable. Fortunately it was not
released.
---

Pushed under the trivial && build-breaker rule.

 src/storage/storage_backend_sheepdog.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/src/storage/storage_backend_sheepdog.c b/src/storage/storage_backend_sheepdog.c
index f389d9b..af15c3b 100644
--- a/src/storage/storage_backend_sheepdog.c
+++ b/src/storage/storage_backend_sheepdog.c
@@ -263,6 +263,7 @@ virStorageBackendSheepdogBuildVol(virConnectPtr conn,
                                   unsigned int flags)
 {
     int ret = -1;
+    virCommandPtr cmd = NULL;

     virCheckFlags(0, -1);

@@ -272,7 +273,7 @@ virStorageBackendSheepdogBuildVol(virConnectPtr conn,
         goto cleanup;
     }

-    virCommandPtr cmd = virCommandNewArgList(COLLIE, "vdi", "create", vol->name, NULL);
+    cmd = virCommandNewArgList(COLLIE, "vdi", "create", vol->name, NULL);
     virCommandAddArgFormat(cmd, "%llu", vol->target.capacity);
     virStorageBackendSheepdogAddHostArg(cmd, pool);
     if (virCommandRun(cmd, NULL) < 0)
-- 
2.2.2




More information about the libvir-list mailing list