[libvirt] [PATCHv2 4/7] phyp: Fix error messages mentioning memory

Peter Krempa pkrempa at redhat.com
Mon Mar 2 13:45:36 UTC 2015


On Thu, Feb 26, 2015 at 13:29:15 +0100, Martin Kletzander wrote:
> On Wed, Feb 25, 2015 at 11:22:03AM +0100, Peter Krempa wrote:
> >The messages for currentMemory and memory were swapped.
> >---
> >
> >Notes:
> >    Version 2:
> >    - new in series
> >
> > src/phyp/phyp_driver.c | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> >diff --git a/src/phyp/phyp_driver.c b/src/phyp/phyp_driver.c
> >index c1d6eb2..a1e390d 100644
> >--- a/src/phyp/phyp_driver.c
> >+++ b/src/phyp/phyp_driver.c
> >@@ -3488,14 +3488,14 @@ phypBuildLpar(virConnectPtr conn, virDomainDefPtr def)
> >
> >     if (!def->mem.cur_balloon) {
> >         virReportError(VIR_ERR_XML_ERROR, "%s",
> >-                       _("Field <memory> on the domain XML file is missing or has "
> >+                       _("Field <currentMemory> on the domain XML file is missing or has "
> >                          "invalid value."));
> 
> You could've wrapped the message to fit into 80 columns and remove the
> dot at the and as well.  ACK with that changed.
> 
> >         goto cleanup;
> >     }
> >
> >     if (!virDomainDefGetMemoryInitial(def)) {
> >         virReportError(VIR_ERR_XML_ERROR, "%s",
> >-                       _("Field <currentMemory> on the domain XML file is missing or "
> >+                       _("Field <memory> on the domain XML file is missing or "
> 
> ditto
> 
> >                          "has invalid value."));
> >         goto cleanup;
> >     }

I've tweaked the messages and pushed the patch.

Peter
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20150302/ce34fc7b/attachment-0001.sig>


More information about the libvir-list mailing list