[libvirt] [libvirt-designer 2/2] Fix gvir_designer_domain_get_guest_full() leak

Christophe Fergeau cfergeau at redhat.com
Wed Mar 4 12:26:17 UTC 2015


One GVirConfigCapabilitiesGuestArch instance was created for each loop
iteration, but it was never unref'ed, causing a memory leak.
---
 libvirt-designer/libvirt-designer-domain.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/libvirt-designer/libvirt-designer-domain.c b/libvirt-designer/libvirt-designer-domain.c
index 6629fb5..cefefea 100644
--- a/libvirt-designer/libvirt-designer-domain.c
+++ b/libvirt-designer/libvirt-designer-domain.c
@@ -999,10 +999,12 @@ gvir_designer_domain_get_guest_full(GVirDesignerDomain *design,
 
         if (g_str_equal(guestarch, wantarch) &&
             guestos == ostype) {
+            g_object_unref(G_OBJECT(arch));
             ret = g_object_ref(guest);
             goto cleanup;
         }
 
+        g_object_unref(G_OBJECT(arch));
         tmp = tmp->next;
     }
 
-- 
2.1.0




More information about the libvir-list mailing list