[libvirt] [PATCH] storage: tweak condition to properly test lseek

Peter Krempa pkrempa at redhat.com
Wed Mar 4 13:57:39 UTC 2015


On Tue, Mar 03, 2015 at 12:10:46 -0700, Eric Blake wrote:
> On 03/03/2015 08:57 AM, Erik Skultety wrote:
> > According to the POSIX standard, off_t (returned by lseek) is defined as
> > signed integral type no shorter than int. Because our offset variable is defined
> > as unsigned long long, the original check was passed successfully if UINT64_MAX had
> > been used as offset value, due to implicit conversion.
> > 
> > Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1177219
> > ---
> >  src/fdstream.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> ACK.

Pushed; Erik still doesn't have commit access.

Peter
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20150304/c7c2893f/attachment-0001.sig>


More information about the libvir-list mailing list