[libvirt] [PATCH v2] qemu: Allow spaces in disk serial
Ján Tomko
jtomko at redhat.com
Thu Mar 5 10:56:43 UTC 2015
On Tue, Feb 24, 2015 at 04:34:25PM +0100, Michal Privoznik wrote:
> https://bugzilla.redhat.com/show_bug.cgi?id=1195660
>
> There's been a bug report appearing on the qemu-devel list, that
> libvirt is unable to pass spaces in disk serial number [1]. Not only
> our RNG schema forbids that, the code is not prepared either. However,
> with a bit of escaping (if needed) we can allow spaces there.
>
> 1: https://lists.gnu.org/archive/html/qemu-devel/2015-02/msg04041.html
>
> Signed-off-by: Michal Privoznik <mprivozn at redhat.com>
> ---
>
> diff to v1:
> - Switch from virBufferEscapeShell to virBufferEscape
>
> docs/schemas/domaincommon.rng | 2 +-
> src/qemu/qemu_command.c | 5 ++--
> .../qemuxml2argvdata/qemuxml2argv-disk-serial.args | 7 ++++++
> .../qemuxml2argvdata/qemuxml2argv-disk-serial.xml | 27 ++++++++++++++++++++++
> tests/qemuxml2argvtest.c | 5 ++++
> 5 files changed, 43 insertions(+), 3 deletions(-)
> create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-disk-serial.args
> create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-disk-serial.xml
>
ACK
Jan
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20150305/2862067b/attachment-0001.sig>
More information about the libvir-list
mailing list