[libvirt] [PATCH v2 08/24] network_conf: Turn virNetworkObjList into virObject

Peter Krempa pkrempa at redhat.com
Thu Mar 5 14:55:30 UTC 2015


On Thu, Mar 05, 2015 at 12:05:09 +0100, Michal Privoznik wrote:
> Well, one day this will be self-locking object, but not today.
> But lets prepare the code for that! Moreover,
> virNetworkObjListFree() is no longer needed, so turn it into
> virNetworkObjListDispose().
> 
> Signed-off-by: Michal Privoznik <mprivozn at redhat.com>
> ---
>  cfg.mk                            |  1 -
>  src/conf/network_conf.c           | 53 +++++++++++++++++++++++++++++----------
>  src/conf/network_conf.h           | 11 ++++----
>  src/libvirt_private.syms          |  2 +-
>  src/network/bridge_driver.c       |  5 ++--
>  src/parallels/parallels_network.c |  7 +++---
>  src/test/test_driver.c            | 13 ++++------
>  7 files changed, 57 insertions(+), 35 deletions(-)

I still dislike the fact that you move the virNetworkObjTaint() function
but I don't want to waste more time on it than writing this rant.

ACK

Peter

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20150305/07c1ac1c/attachment-0001.sig>


More information about the libvir-list mailing list