[libvirt] [PATCH v3 1/9] Implement public API for virDomainGetIOThreadsInfo

Ján Tomko jtomko at redhat.com
Thu Mar 5 16:21:41 UTC 2015


On Thu, Mar 05, 2015 at 07:45:51AM -0500, John Ferlan wrote:
> >> +    unsigned char *cpumap;             /* CPU map for thread */
> >> +    int cpumaplen;                     /* cpumap size */
> > 
> >> +    size_t nresources;                 /* count of resources using IOThread */
> >> +    char **resources;                  /* array of resources using IOThread */
> > 
> > "resources" is too vague.
> 
> Suggestion?  Is "devices" better?
> 
> Today it's the disk source path, but I remember reading something where
> an IOThread could be potentially used for something else (perhaps
> network, but I cannot find the reference quickly).
> 

I just worry that putting the path here could be a problem sometime in
the future if the attribute gets extended (I think some of the Block*
APIs had that problem).

Perhaps Peter or Eric will voice their opinion.

Jan
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20150305/9095f682/attachment-0001.sig>


More information about the libvir-list mailing list