[libvirt] [PATCH v4 5/9] Implement public API for getting/setting specific IOThread pinning

John Ferlan jferlan at redhat.com
Fri Mar 6 11:53:20 UTC 2015


>> Yes - although based on reviews from yesterday it wasn't totally clear
>> if having a GetIOThreadPin in addition to GetIOThreadsInfo was
>> requested, so I added it to be "safe", but can remove it.
>>
>> There is a GetVcpus and a GetVcpuPinInfo and the IOThreads code mirrors
>> that.
> 
> Ah that's more of a historical accident :-) We added GetVcpus first to
> simply return the number of VCPUs and later added GetVcpuPinInfo to
> return pinning info. If we were doing it fresh, we'd only add the
> GetVcpuPinInfo since it offers the superset of features.
> 
> If you repost without GetIOThreadPin, I'd ack the rest.
> 
> BTW, no need to repost the first 3 I already acked.
> 

OK - I'll push 1-4 since they're ACK'd (I have a related libvirt-python
patches ready too), then repost the last 5.

Is this something that'll need adjustments in the perl bindings? (not
that I know perl all that well)

Tks -

John




More information about the libvir-list mailing list