[libvirt] [PATCH] sanlock: Don't spam logs with "target pid not found"
Daniel P. Berrange
berrange at redhat.com
Mon Mar 9 12:31:02 UTC 2015
On Fri, Mar 06, 2015 at 04:58:22PM +0100, Jiri Denemark wrote:
> Commit v1.2.4-52-gda879e5 fixed issues with domains started before
> sanlock driver was enabled by checking whether a running domain is
> registered with sanlock and if it's not, sanlock driver is basically
> ignored for the domain.
>
> However, it was checking this even for domain which has just been
> started and no sanlock_* API was called for them yet. This results in
>
> cmd 9 target pid 2135544 not found
>
> error messages to appear in sanlock.log whenever we start a new domain.
>
> This patch avoids this useless check for freshly started domains.
>
> Signed-off-by: Jiri Denemark <jdenemar at redhat.com>
> ---
> src/locking/domain_lock.c | 22 ++++++++++++----------
> src/locking/lock_driver.h | 12 +++++++++++-
> src/locking/lock_driver_lockd.c | 2 +-
> src/locking/lock_driver_sanlock.c | 9 ++++++---
> src/locking/lock_manager.c | 2 +-
> 5 files changed, 31 insertions(+), 16 deletions(-)
ACK, this makes sense.
Regards,
Daniel
--
|: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org -o- http://virt-manager.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|
More information about the libvir-list
mailing list