[libvirt] [PATCH] virnet*: Don't unlock object in dispose
Daniel P. Berrange
berrange at redhat.com
Tue Mar 10 10:32:49 UTC 2015
On Tue, Mar 10, 2015 at 11:20:14AM +0100, Michal Privoznik wrote:
> As of bba93d40 all of our RPC objects are derived from
> virObjectLockable. However, during rewrite some errors sneaked
> in. For instance, the dispose functions to virNetClient and
> virNetServerClient objects were not only freeing allocated
> memory, but unlocking themselves. This is wrong. Object should
> never disappear while locked.
ACK, ref counting ensures we have the only reference and are
unlocked when dispose runs.
Regards,
Daniel
--
|: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org -o- http://virt-manager.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|
More information about the libvir-list
mailing list