[libvirt] [PATCH v3 11/15] struct _virNetworkDriverState: Annotate items

Michal Privoznik mprivozn at redhat.com
Tue Mar 10 16:45:17 UTC 2015


In order to drop network driver lock, lets annotate which
structure items are immutable, which have self-locking
APIs and so on.

Signed-off-by: Michal Privoznik <mprivozn at redhat.com>
---
 src/network/bridge_driver_platform.h | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/src/network/bridge_driver_platform.h b/src/network/bridge_driver_platform.h
index b7492e6..d9cf6a8 100644
--- a/src/network/bridge_driver_platform.h
+++ b/src/network/bridge_driver_platform.h
@@ -34,8 +34,10 @@
 struct _virNetworkDriverState {
     virMutex lock;
 
+    /* Immutable pointer, self-locking APIs */
     virNetworkObjListPtr networks;
 
+    /* Immutable pointer, Immutable objects */
     char *networkConfigDir;
     char *networkAutostartDir;
     char *stateDir;
@@ -44,6 +46,7 @@ struct _virNetworkDriverState {
     char *radvdStateDir;
     dnsmasqCapsPtr dnsmasqCaps;
 
+    /* Immutable pointer, self-locking APIs */
     virObjectEventStatePtr networkEventState;
 };
 
-- 
2.0.5




More information about the libvir-list mailing list