[libvirt] [PATCH 4/4] parallels: prevent domain define only if vcpupin is specified

Maxim Nestratov mnestratov at parallels.com
Tue Mar 10 20:12:22 UTC 2015


and their settings differ from common cpumask

Signed-off-by: Maxim Nestratov <mnestratov at parallels.com>
---
 src/parallels/parallels_sdk.c |   14 ++++++++++++--
 1 files changed, 12 insertions(+), 2 deletions(-)

diff --git a/src/parallels/parallels_sdk.c b/src/parallels/parallels_sdk.c
index 4ec9161..fde908b 100644
--- a/src/parallels/parallels_sdk.c
+++ b/src/parallels/parallels_sdk.c
@@ -1808,14 +1808,24 @@ prlsdkCheckUnsupportedParams(PRL_HANDLE sdkdom, virDomainDefPtr def)
     if (def->cputune.shares ||
         def->cputune.sharesSpecified ||
         def->cputune.period ||
-        def->cputune.quota ||
-        def->cputune.nvcpupin) {
+        def->cputune.quota) {
 
         virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s",
                        _("cputune is not supported by parallels driver"));
         return -1;
     }
 
+    if (def->cputune.vcpupin) {
+       for (i = 0; i < def->vcpus; i++) {
+            if (!virBitmapEqual(def->cpumask,
+                                def->cputune.vcpupin[i]->cpumask)) {
+                virReportError(VIR_ERR_CONFIG_UNSUPPORTED,
+                               "%s", _("vcpupin cpumask differs from default cpumask"));
+                return -1;
+            }
+        }
+    }
+
 
     /*
      * Though we don't support NUMA configuration at the moment
-- 
1.7.1




More information about the libvir-list mailing list