[libvirt] [PATCH 4/6] xenapi: Resolve Coverity NULL_RETURNS

John Ferlan jferlan at redhat.com
Tue Mar 10 23:20:27 UTC 2015


Coverity points out that the return from virDomainDefParseString is
not checked in xenapiDomainCreateXML like it should be which could
end up in a pointer dereference

Signed-off-by: John Ferlan <jferlan at redhat.com>
---
 src/xenapi/xenapi_driver.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/src/xenapi/xenapi_driver.c b/src/xenapi/xenapi_driver.c
index 821e9d9..148ff9b 100644
--- a/src/xenapi/xenapi_driver.c
+++ b/src/xenapi/xenapi_driver.c
@@ -560,6 +560,8 @@ xenapiDomainCreateXML(virConnectPtr conn,
                                                      priv->caps, priv->xmlopt,
                                                      1 << VIR_DOMAIN_VIRT_XEN,
                                                      parse_flags);
+    if (!defPtr)
+        return NULL;
     createVMRecordFromXml(conn, defPtr, &record, &vm);
     virDomainDefFree(defPtr);
     if (record) {
-- 
2.1.0




More information about the libvir-list mailing list