[libvirt] [PATCH 00/12] qemu: Refactor block stats gathering and implement summary stats

Peter Krempa pkrempa at redhat.com
Wed Mar 11 09:08:35 UTC 2015


On Wed, Mar 11, 2015 at 10:05:59 +0100, Ján Tomko wrote:
> On Tue, Mar 10, 2015 at 05:26:29PM +0100, Peter Krempa wrote:
> > Peter Krempa (12):
> >   qemu: Use macro to set block stats typed parameters
> >   qemu: monitor: Drop parsing of 'errs' from block info
> >   qemu: blockstats: Switch to caller allocated hash table
> >   test: qemu: Fix qemu monitor test utils to allow testing HMP
> >   qemu: monitor: Implement HMP version for listing all block device
> >     stats
> >   qemu: monitor: Convert common code to a macro
> >   qemu: monitor: Count block stats fields in
> >     qemuMonitorGetAllBlockStatsInfo
> >   qemu: Split out working code qemuDomainBlockStats
> >   qemu: blockstats: Add support for totalled block statistics
> >   qemu: blockstats: Refactor qemuDomainBlockStatsFlags
> >   test: qemu: json: Avoid using the now obsolete functions
> >   qemu: monitor: Kill qemuMonitorGetBlockStats(Info,ParamsNumber)
> > 
> >  src/qemu/qemu_driver.c       | 299 ++++++++++++++++++++-----------------------
> >  src/qemu/qemu_monitor.c      | 106 ++++++---------
> >  src/qemu/qemu_monitor.h      |  15 ---
> >  src/qemu/qemu_monitor_json.c | 233 ++++-----------------------------
> >  src/qemu/qemu_monitor_json.h |  15 +--
> >  src/qemu/qemu_monitor_text.c | 256 ++++++++++++++----------------------
> >  src/qemu/qemu_monitor_text.h |  16 +--
> >  tests/Makefile.am            |   8 +-
> >  tests/qemumonitorjsontest.c  |  65 ++++------
> >  tests/qemumonitortest.c      |  89 ++++++++++++-
> >  tests/qemumonitortestutils.c |   3 +-
> >  tools/virsh.pod              |   5 +-
> >  12 files changed, 425 insertions(+), 685 deletions(-)
> 
> ACK series.

Thanks for the review.

> 
> Did you just add a feature while removing 260 lines of code?

I'd gladly kill even more code in the text monitor section if I would be
allowed to :)

> 
> Jan

Peter
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20150311/80f9d618/attachment-0001.sig>


More information about the libvir-list mailing list