[libvirt] [PATCH] Clarify the meaning of version in redirdev filters

Ján Tomko jtomko at redhat.com
Thu Mar 12 12:21:40 UTC 2015


The version attribute in redirdev filters refers to the revision
of the device, not the version of the USB protocol.

Explicitly state that this is not the USB protocol and remove references
to those round version numbers that resemble USB protocol versions.

https://bugzilla.redhat.com/show_bug.cgi?id=1177237
---
 docs/formatdomain.html.in | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/docs/formatdomain.html.in b/docs/formatdomain.html.in
index ede20de..40e2b29 100644
--- a/docs/formatdomain.html.in
+++ b/docs/formatdomain.html.in
@@ -3320,7 +3320,7 @@
       <boot order='1'/>
     </redirdev>
     <redirfilter>
-      <usbdev class='0x08' vendor='0x1234' product='0xbeef' version='2.00' allow='yes'/>
+      <usbdev class='0x08' vendor='0x1234' product='0xbeef' version='2.56' allow='yes'/>
       <usbdev allow='no'/>
     </redirfilter>
   </devices>
@@ -3363,7 +3363,8 @@
         <code>class</code> attribute is the USB Class code, for example,
         0x08 represents mass storage devices. The USB device can be addressed by
         vendor / product id using the <code>vendor</code> and <code>product</code> attributes.
-        <code>version</code> is the bcdDevice value of USB device, such as 1.00, 1.10 and 2.00.
+        <code>version</code> is the device revision from the bcdDevice field (not
+        the version of the USB protocol).
         These four attributes are optional and <code>-1</code> can be used to allow
         any value for them. <code>allow</code> attribute is mandatory,
         'yes' means allow, 'no' for deny.
-- 
2.0.5




More information about the libvir-list mailing list