[libvirt] [PATCH v4 1/7] bridge_driver: Don't access global driver randomly

Peter Krempa pkrempa at redhat.com
Fri Mar 13 09:17:15 UTC 2015


On Thu, Mar 12, 2015 at 15:39:15 +0100, Michal Privoznik wrote:
> Well, network driver code has the driver accessible as a global
> variable. This makes any rework hard, as it's unclear where the
> variable is accessed and/or modified. Lets just pass the driver
> as a parameter to all functions where needed.
> 
> Signed-off-by: Michal Privoznik <mprivozn at redhat.com>
> ---
>  src/network/bridge_driver.c | 430 +++++++++++++++++++++++++-------------------
>  1 file changed, 247 insertions(+), 183 deletions(-)

ACK, the renaming to network driver made it really easy to review.

Peter
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20150313/a751f899/attachment-0001.sig>


More information about the libvir-list mailing list