[libvirt] [PATCH 08/12] Convert virDomainVcpuPinFindByVcpu into virDomainPinFindByVcpu

Ján Tomko jtomko at redhat.com
Mon Mar 16 12:52:36 UTC 2015


On Fri, Mar 13, 2015 at 11:11:52PM -0400, John Ferlan wrote:
> Make common between Vcpu and IOThreads

I feel like this sentence is missing something.

> 
> Signed-off-by: John Ferlan <jferlan at redhat.com>
> ---
>  src/conf/domain_conf.c   | 24 ++++++++++++------------
>  src/conf/domain_conf.h   |  6 +++---
>  src/libvirt_private.syms |  2 +-
>  src/qemu/qemu_driver.c   | 12 ++++++------
>  src/qemu/qemu_process.c  | 12 ++++++------
>  5 files changed, 28 insertions(+), 28 deletions(-)
> 
> diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
> index efc01bd..75d75bc 100644
> --- a/src/conf/domain_conf.c
> +++ b/src/conf/domain_conf.c
> @@ -16693,17 +16693,17 @@ virDomainPinIsDuplicate(virDomainPinDefPtr *def,
>  }
>  
>  virDomainPinDefPtr
> -virDomainVcpuPinFindByVcpu(virDomainPinDefPtr *def,
> -                           int nvcpupin,
> -                           int vcpu)
> +virDomainPinFindByVcpu(virDomainPinDefPtr *def,
> +                       int npin,
> +                       int id)

The second reference to Vcpu should be removed as well:
virDomainPinFindById
or even simpler:
virDomainPinFind
since I can't imagine doing a find according to any other attribute.

Jan
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20150316/e6299527/attachment-0001.sig>


More information about the libvir-list mailing list