[libvirt] [PATCH v2] rpm-build: use pkg-config to detect wireshark presence
Pavel Hrdina
phrdina at redhat.com
Tue Mar 17 10:43:29 UTC 2015
On Tue, Mar 17, 2015 at 10:04:18AM +0000, Daniel P. Berrange wrote:
> On Tue, Mar 17, 2015 at 09:18:06AM +0100, Pavel Hrdina wrote:
> > Wireshark supports pkg-config since 1.11.3. Right now we build
> > wireshark-dissectior tool as default trough rpm build only on
> > fedora >= 21 and there is new wireshark that supports pkg-config.
> > If someone wants to build libvirt with wireshark-dissector against old
> > wireshark, they should specify the location by hand.
> >
> > This patch is mainly to fix wrong dependency on wireshark binary as it
> > doesn't make sense to require that binary file to just get version info
> > of that package in makefile.
> >
> > Signed-off-by: Pavel Hrdina <phrdina at redhat.com>
>
> ACK
Thanks, pushed now.
Pavel
>
>
> Regards,
> Daniel
> --
> |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :|
> |: http://libvirt.org -o- http://virt-manager.org :|
> |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
> |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|
More information about the libvir-list
mailing list