[libvirt] [PATCH 5/7] parallels: make E1000 network adapter type default

Michal Privoznik mprivozn at redhat.com
Tue Mar 17 14:14:48 UTC 2015


On 13.03.2015 16:52, Maxim Nestratov wrote:
> Signed-off-by: Maxim Nestratov <mnestratov at parallels.com>
> ---
>  src/parallels/parallels_sdk.c |    4 ++++
>  1 files changed, 4 insertions(+), 0 deletions(-)
> 
> diff --git a/src/parallels/parallels_sdk.c b/src/parallels/parallels_sdk.c
> index 9588163..748a308 100644
> --- a/src/parallels/parallels_sdk.c
> +++ b/src/parallels/parallels_sdk.c
> @@ -2665,6 +2665,10 @@ static int prlsdkAddNet(PRL_HANDLE sdkdom, parallelsConnPtr privconn, virDomainN
>      pret = PrlVmDevNet_SetMacAddress(sdknet, macstr);
>      prlsdkCheckRetGoto(pret, cleanup);
>  
> +    /* Other alternatives: PNT_VIRTIO, PNT_RTL */
> +    pret = PrlVmDevNet_SetAdapterType(sdknet, PNT_E1000);
> +    prlsdkCheckRetGoto(pret, cleanup);
> +
>      if (net->type == VIR_DOMAIN_NET_TYPE_NETWORK) {
>          if (STREQ(net->data.network.name, PARALLELS_DOMAIN_ROUTED_NETWORK_NAME)) {
>              pret = PrlVmDev_SetEmulatedType(sdknet, PNA_ROUTED);
> 

I'd appreciate if this would go through XML. There's option for
hypervisor drivers to register a callback to fill in defaults after XML
is parsed. That's perfect place to set e1000 as default vNIC model (if
not already provided by user in XML). And here just set model requested
in XML (or throw an error if unsupported).

Michal




More information about the libvir-list mailing list