[libvirt] [PATCH 2/4] parallels: don't forget to unlock domain if unregister fails

[Michal Privoznik]

On 13.03.2015 16:40, Maxim Nestratov wrote:
> Signed-off-by: Maxim Nestratov <mnestratov at parallels.com>
> ---
>  src/parallels/parallels_driver.c |    7 ++++++-
>  1 files changed, 6 insertions(+), 1 deletions(-)
> 
> diff --git a/src/parallels/parallels_driver.c b/src/parallels/parallels_driver.c
> index d2907cf..aeb43ad 100644
> --- a/src/parallels/parallels_driver.c
> +++ b/src/parallels/parallels_driver.c
> @@ -948,6 +948,7 @@ parallelsDomainUndefineFlags(virDomainPtr domain,
>  {
>      parallelsConnPtr privconn = domain->conn->privateData;
>      virDomainObjPtr dom = NULL;
> +    int ret;
>  
>      virCheckFlags(0, -1);
>  
> @@ -957,7 +958,11 @@ parallelsDomainUndefineFlags(virDomainPtr domain,
>          return -1;
>      }
>  
> -    return prlsdkUnregisterDomain(privconn, dom);
> +    ret = prlsdkUnregisterDomain(privconn, dom);
> +    if (ret)
> +         virObjectUnlock(dom);
> +
> +    return ret;
>  }
>  
>  static int
> 

Nice catch. ACK.

Michal