[libvirt] [PATCH] util: clean up #includes of virnetdevopenvswitch.h

Eric Blake eblake at redhat.com
Tue Mar 17 19:02:13 UTC 2015


On 03/17/2015 12:59 PM, Laine Stump wrote:
> On 03/17/2015 01:54 PM, Eric Blake wrote:
>> On 03/17/2015 11:50 AM, Laine Stump wrote:
>>> virnetdevopenvswitch.h declares a few functions that can be called to
>>> add ports to and remove them from OVS bridges, and retrieve the
>>> migration data for a port. It does not contain any data definitions
>>> that are used by domain_conf.h. But for some reason, domain_conf.h
>>> virnetdevopenvswitch.h should be directly #including it. This adds a
>> That sentence didn't read well.  Maybe
>>
>> But for some reason, domain_conf.h was directly #including
>> virnetdevopenvswitch.h.
> 
> Urgh. Yes. Either I accidentally hit an arrow key while typing, or it's
> another case of artifacts on the screen messing me up (although I've
> only noticed that with Thunderbird, not with emacs).

Ah, I know what happened.  You typed 'domain_conf.h #includes ...', but
since '#includes' was at the start of a new line, git commit treated it
as a comment line and nuked that section of your sentence.  (I hate when
that happens - I've been bit when trying to paste terminal sequences run
as root where my prompt was #)

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 604 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20150317/69db8508/attachment-0001.sig>


More information about the libvir-list mailing list