[libvirt] [PATCH] libvirt: move default nwfilters to datadir.

Daniel P. Berrange berrange at redhat.com
Tue Mar 17 19:04:38 UTC 2015


On Tue, Mar 17, 2015 at 06:52:31PM +0000, Dimitri John Ledkov wrote:
> libvirt runs correctly without any configuration files, as sensible
> defaults are used throughout. This commit introduces a layer for
> nwfilter configuration. This means that default filters are shipped in
> /usr/share/libvirt/nwfilter/ directory, which can be overridden by
> things in /etc/libvirt/nwfilter. This is similar to configuration
> splits as observed in udev, systemd, XDG Base Directory Specification
> and so on. This will make a distinction and make it obvious if any of
> the nwfilters are modified by the administrator.

I think this is really not something we want to do. Having multiple
directories to store configs in is going to have more fallout than
your patch shows. For a start this breaks the ability to delete these
filters, since the deletion code assumes they're in a particular
directory. Now if the same named filter is present in both locations
the delete API does not know which to delete.

If we were doing this again today, we'd simply not ever install  any
filters by default. Leave it entirely upto the app/admin using libvirt
to decide which filters are present. To that end we already split the
filters off into a separate optional RPM, so that users can skip their
installation.  So if people want to modify these, we should really
just be recommending that they not install this RPM in the first place


Regards,
Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|




More information about the libvir-list mailing list