[libvirt] [RFC PATCH 0/2] Vbox: Add support for virDomainSendKey

Dawid Zamirski dzamirski at datto.com
Thu Mar 19 21:43:55 UTC 2015


Hello,

Those small patches implement virDomainSendKey support in VBOX driver. However,
the VBOX SDK does not support "holdtime" so I used usleep to wait for that time
before sending "key-up" scancodes. This makes it behave similarly to QEMU
driver, however I'm not sure if that way of handling this would be preferred.
Another option, would be to ignore holdtime argument and make virDomainSendKey 
work the same as via VBoxManage cli tool where one has to send
"key-down" scancodes followed by "key-up" scancodes. For this RFC paches, I've
choosen to make it work as close to the public API documentation.


Dawid Zamirski (2):
  vbox: Register IKeyboard with the unified API.
  vbox: Implement virDomainSendKey

 src/vbox/vbox_common.c        | 107 ++++++++++++++++++++++++++++++++++++++++++
 src/vbox/vbox_common.h        |   1 +
 src/vbox/vbox_tmpl.c          |  27 +++++++++++
 src/vbox/vbox_uniformed_api.h |   8 ++++
 4 files changed, 143 insertions(+)

-- 
2.3.3




More information about the libvir-list mailing list