[libvirt] [PATCH 1/2] cgroup: Add accessors for cpuset.memory_migrate

Martin Kletzander mkletzan at redhat.com
Fri Mar 20 12:33:53 UTC 2015


On Fri, Mar 20, 2015 at 07:08:45AM -0400, John Ferlan wrote:
>
>
>On 03/11/2015 08:39 AM, Martin Kletzander wrote:
>> Signed-off-by: Martin Kletzander <mkletzan at redhat.com>
>> ---
>>  src/libvirt_private.syms |  2 ++
>>  src/util/vircgroup.c     | 42 +++++++++++++++++++++++++++++++++++++++++-
>>  src/util/vircgroup.h     |  5 ++++-
>>  3 files changed, 47 insertions(+), 2 deletions(-)
>>
>
>OK - so with all that I've learned on this - it's an ACK...  Whether I
>remember this the next time it comes up is anyone's guess ;-)
>
>Also, since it's been declared a bool already, if the kernel changes to
>allowing a 2 that I believe would be considered breaking things the
>kernel shouldn't break...
>

"things kernel shouldn't break" :-D  You made my weekend, thanks ;)

I fixed the plus-one error in the second patch and pushed it.  Thanks
for the review.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20150320/546082a5/attachment-0001.sig>


More information about the libvir-list mailing list