[libvirt] [libvirt-designer][PATCH 2/2] Converting tabs to spaces

Michal Privoznik mprivozn at redhat.com
Fri Mar 20 14:38:40 UTC 2015


On 20.03.2015 14:11, Jayashree Deshpande wrote:
> ---
>  libvirt-designer/libvirt-designer-domain.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/libvirt-designer/libvirt-designer-domain.c b/libvirt-designer/libvirt-designer-domain.c
> index 8703884..1dfa6b0 100644
> --- a/libvirt-designer/libvirt-designer-domain.c
> +++ b/libvirt-designer/libvirt-designer-domain.c
> @@ -674,8 +674,8 @@ gvir_designer_domain_add_usb_controllers(GVirDesignerDomain *design)
>   * Returns: (transfer full): the pointer to the new USB redir channel
>   */
>  GVirConfigDomainRedirdev *
> -gvir_designer_domain_add_usb_redir(GVirDesignerDomain *design, 
> -				   GError **error)
> +gvir_designer_domain_add_usb_redir(GVirDesignerDomain *design,
> +                                   GError **error)

This is rather unusual way of sending patches. When posting new version
of patches, they should already be changed according to the review.
Fixups are merged into them, not sent separate. But I'll merge these
two, ACK and push.

Also - there are more functions in the file, that doesn't follow the
pattern.


Michal




More information about the libvir-list mailing list