[libvirt] [PATCH] qemu: Set default SCSI controller model for S390 arch

Jens Freimann jfrei at linux.vnet.ibm.com
Fri Mar 20 17:03:38 UTC 2015


On Fri, Mar 20, 2015 at 04:01:10PM +0100, Boris Fiuczynski wrote:
> When no model is specified in the domain definition for
> a scsi controller and the architectur is s390 than virtio-scsi
> is set as default model.
> 
> Signed-off-by: Boris Fiuczynski <fiuczy at linux.vnet.ibm.com>
> Reviewed-by: Daniel Hansel <daniel.hansel at linux.vnet.ibm.com>
> Reviewed-by: Stefan Zimmermann <stzi at linux.vnet.ibm.com>
> ---
>  src/qemu/qemu_domain.c | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c
> index 41d1263..949bf8b 100644
> --- a/src/qemu/qemu_domain.c
> +++ b/src/qemu/qemu_domain.c
> @@ -1148,6 +1148,13 @@ qemuDomainDeviceDefPostParse(virDomainDeviceDefPtr dev,
>          ARCH_IS_S390(def->os.arch))
>          dev->data.controller->model = VIR_DOMAIN_CONTROLLER_MODEL_USB_NONE;
> 
> +    /* set the default SCSI controller model for S390 arches */
> +    if (dev->type == VIR_DOMAIN_DEVICE_CONTROLLER &&
> +        dev->data.controller->type == VIR_DOMAIN_CONTROLLER_TYPE_SCSI &&
> +        dev->data.controller->model == -1 &&
> +        ARCH_IS_S390(def->os.arch))
> +        dev->data.controller->model = VIR_DOMAIN_CONTROLLER_MODEL_SCSI_VIRTIO_SCSI;
> +

I think it's good to make this the default on s390. So, FWIW

Reviewed-by: Jens Freimann <jfrei at linux.vnet.ibm.com>




More information about the libvir-list mailing list