[libvirt] [PATCH] Fix common misspellings
Martin Kletzander
mkletzan at redhat.com
Mon Mar 23 08:46:03 UTC 2015
On Fri, Mar 20, 2015 at 09:51:23AM -0600, Eric Blake wrote:
>On 03/20/2015 06:21 AM, Martin Kletzander wrote:
>> Wikipedia's list of common misspellings [1] has a machine-readable
>> version. This patch fixes those misspellings mentioned in the list
>> which don't have multiple right variants (as e.g. "accension", which can
>> be both "accession" and "ascension"), such misspellings are left
>> untouched. The list of changes was manually re-checked for false
>> positives.
>>
>> [1] https://en.wikipedia.org/wiki/Wikipedia:Lists_of_common_misspellings/For_machines
>>
>> Signed-off-by: Martin Kletzander <mkletzan at redhat.com>
>> ---
>> This is in no way automated, it's merely a check on whether this makes
>> sense. Also I left out three words and two files which I thought
>> might not be what we want.
>
>Quite the list! As a native speaker...
>
>
>> +++ b/docs/bugs.html.in
>> @@ -11,7 +11,7 @@
>>
>> <p>
>> If you think that an issue with libvirt may have security
>> - implications, <strong>please do not</strong> publically
>> + implications, <strong>please do not</strong> publicly
>
>Correct.
>
>
>> +++ b/docs/schemas/basictypes.rng
>> @@ -115,7 +115,7 @@
>> <!--interface on a device (system). The duid is often used by servers -->
>> <!--such as dnsmasq to assign a specific IP address (and optionally a -->
>> <!--name to an interface. The applicable standards are RFC3315 and -->
>> - <!--RFC6355. These standards actualy require the duid to be fixed for -->
>> + <!--RFC6355. These standards actually require the duid to be fixed for -->
>> <!--the hardward device and applicable to all network interfaces on -->
>
>Alignment is now off.
>
>
>> +++ b/docs/schemas/interface.rng
>> @@ -4,7 +4,7 @@
>> xmlns:v="http://netcf.org/xml/version/1.0"
>> datatypeLibrary="http://www.w3.org/2001/XMLSchema-datatypes">
>> <!-- Versions for this schema are simple integers that are incremented
>> - everytime a changed (but backwards compatible) version
>> + every time a changed (but backwards compatible) version
>> is released. The current version is indicated with the v:serial
>> attribute on the start element.
>> -->
>
>Hmm - we aren't really bumping the version when we change the .rng; is
>that a bug in our process, or a stale comment worth deleting instead of
>spell-checking? But doesn't stop us from taking this hunk now.
>
Well, this has something to do with netcf, I guess. Probably Laine
(Cc'd) would be the one to answer that.
>
>> @@ -77,7 +77,7 @@
>> are two weeks or less in duration. If a problem is identified
>> with a proposed patch for a security issue, requiring further
>> investigation and bug fixing, the embargo clock may be restarted.
>> - In exceptional circumstances longer initial embargos may be
>> + In exceptional circumstances longer initial embargoes may be
>
>This one is ambiguous (I've seen both spellings; zeros/zeroes is another
>such word), but Thunderbird's US spell-check dictionary prefers
>embargoes, so go for it.
>
My en_GB.utf8 ispell only allows "embargoes". What is your opinion on
"dependant" and similar words I've left out?
>ACK to all these changes (modulo the alignment fix).
>
I pushed the patch with the alignment fixed and "publicly" kept,
thanks for the reviews.
Martin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20150323/adf475ac/attachment-0001.sig>
More information about the libvir-list
mailing list