[libvirt] [PATCH 4/6] qemu: check if domain is really active when do setvcpus with --live

Peter Krempa pkrempa at redhat.com
Tue Mar 24 16:15:28 UTC 2015


On Fri, Mar 20, 2015 at 15:39:02 +0100, Pavel Hrdina wrote:
> From: Luyao Huang <lhuang at redhat.com>
> 
> Commit e105dc9 fix setting vcpus for offline domain, but forget check
> if vm is active when pass VIR_DOMAIN_AFFECT_LIVE flags.
> 
>  # virsh setvcpus test3 4 --live
>  error: Failed to create controller cpu for group: No such file or directory
> 
> Add a check if we pass VIR_DOMAIN_AFFECT_LIVE flags.
> 
> Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1204006
> 
> Signed-off-by: Luyao Huang <lhuang at redhat.com>
> Signed-off-by: Pavel Hrdina <phrdina at redhat.com>
> ---
>  src/qemu/qemu_driver.c | 14 ++++++++------
>  1 file changed, 8 insertions(+), 6 deletions(-)

NACK, after the virDomainLiveConfigHelperMethod gets moved, this is not
logner necessary as it contains the same code.

Peter
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20150324/59956741/attachment-0001.sig>


More information about the libvir-list mailing list