[libvirt] [PATCH 7/6] qemu: move virDomainLiveConfigHelperMethod right after BeginJob

Pavel Hrdina phrdina at redhat.com
Tue Mar 24 16:57:22 UTC 2015


On Tue, Mar 24, 2015 at 05:13:07PM +0100, Peter Krempa wrote:
> On Fri, Mar 20, 2015 at 15:58:56 +0100, Pavel Hrdina wrote:
> > We should call virDomainLiveConfigHelperMethod ASAP because this
> > function transfers VIR_DOMAIN_AFFECT_CURRENT to VIR_DOMAIN_AFFECT_LIVE
> > or VIR_DOMAIN_AFFECT_CONFIG.  All other additional checks for those two
> > flags should consider that the user give us VIR_DOMAIN_AFFECT_CURRENT.
> > 
> > Signed-off-by: Pavel Hrdina <phrdina at redhat.com>
> > ---
> >  src/qemu/qemu_driver.c | 8 ++++----
> >  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> ACK, although this should be 0.5/6 or 1.5/6. Basically just push this
> first.
> 
> Peter

Thanks for review, I'll push it shortly.

Pavel




More information about the libvir-list mailing list