[libvirt] [PATCH] Document that USB hostdevs do not need nodeDettach

Ján Tomko jtomko at redhat.com
Wed Mar 25 08:02:48 UTC 2015


On Tue, Mar 24, 2015 at 05:03:08PM -0400, John Ferlan wrote:
> 
> 
> On 03/23/2015 01:16 PM, Ján Tomko wrote:
> > The virNodeDeviceDettach API only works on PCI devices.
> > 
> > Originally added by commit 10d3272e, but the API never
> > supported USB devices.
> > 
> > Reported by: Martin Polednik <mpolednik at redhat.com>
> > ---
> >  docs/formatdomain.html.in | 19 +++++++++----------
> >  tools/virsh.pod           | 17 ++++++++---------
> >  2 files changed, 17 insertions(+), 19 deletions(-)
> > 
> 
> ACK -
> 
> Should we say to call virNodeDeviceDetachFlags instead of
> virNodeDeviceDettach?

That API requires the driver name (allowing vfio passthrough)
and does not have the typo.

I made the change and pushed the patch.

Jan
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20150325/80d0a482/attachment-0001.sig>


More information about the libvir-list mailing list