[libvirt] [PATCH 2/3] daemon: Clear fake domain def object that is used to check ACL prior to use

Peter Krempa pkrempa at redhat.com
Wed Mar 25 08:35:07 UTC 2015


The fake object is used to pass the domain name and UUID to the ACL code
for events where we don't have the full domain def when dispatching
events. The rest of the entries would be left uninitialized. While this
is not a problem code-wise as the used fields are initialized it looks
ugly in the debugger.
---
 daemon/remote.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/daemon/remote.c b/daemon/remote.c
index 62a4728..8646b06 100644
--- a/daemon/remote.c
+++ b/daemon/remote.c
@@ -150,6 +150,7 @@ remoteRelayDomainEventCheckACL(virNetServerClientPtr client,
     /* For now, we just create a virDomainDef with enough contents to
      * satisfy what viraccessdriverpolkit.c references.  This is a bit
      * fragile, but I don't know of anything better.  */
+    memset(&def, 0, sizeof(def));
     def.name = dom->name;
     memcpy(def.uuid, dom->uuid, VIR_UUID_BUFLEN);

-- 
2.2.2




More information about the libvir-list mailing list