[libvirt] [PATCH v2] Don't validata filesystem target type

Guido Günther agx at sigxcpu.org
Wed Mar 25 14:26:43 UTC 2015


On Wed, Mar 25, 2015 at 10:23:21AM +0100, Michal Privoznik wrote:
> On 25.03.2015 09:47, Guido Günther wrote:
> > When using QEMU's 9pfs the target "dir" element is not necessarily an
> > absolute path but merely an arbitrary identifier. So validation in that
> > case currently fails with the misleading
> > 
> >    $ virt-xml-validate /tmp/test.xml
> >    Relax-NG validity error : Extra element devices in interleave
> >    /tmp/test.xml:24: element devices: Relax-NG validity error : Element domain failed to validate content
> >    /tmp/test.xml fails to validate
> > ---
> >  docs/schemas/domaincommon.rng | 4 +---
> >  1 file changed, 1 insertion(+), 3 deletions(-)
> > 
> > diff --git a/docs/schemas/domaincommon.rng b/docs/schemas/domaincommon.rng
> > index ebd9299..79cbb02 100644
> > --- a/docs/schemas/domaincommon.rng
> > +++ b/docs/schemas/domaincommon.rng
> > @@ -2009,9 +2009,7 @@
> >        </choice>
> >        <interleave>
> >          <element name="target">
> > -          <attribute name="dir">
> > -            <ref name="absDirPath"/>
> > -          </attribute>
> > +          <attribute name="dir"/>
> >            <empty/>
> >          </element>
> >          <optional>
> > 
> 
> ACK

Pushed. Thanks.
 -- Guido




More information about the libvir-list mailing list