[libvirt] [PATCH] qemu: end the job when try to blockcopy to non-file destination

[Ján Tomko]

On Fri, Mar 27, 2015 at 05:16:41PM +0800, Shanzhi Yu wrote:
> Blockcopy to non-file destination is not supported according the code while
> a 'goto endjob' is missed after check the destination which lead qemu try
> to do drive-mirror.
> 
> Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1206406
> Signed-off-by: Shanzhi Yu <shyu at redhat.com>
> ---
>  src/qemu/qemu_driver.c | 1 +
>  1 file changed, 1 insertion(+)

ACK and pushed.

Jan
> 
> diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c
> index db4f0b4..f07e4fb 100644
> --- a/src/qemu/qemu_driver.c
> +++ b/src/qemu/qemu_driver.c
> @@ -16642,6 +16642,7 @@ qemuDomainBlockCopyCommon(virDomainObjPtr vm,
>      if (!virStorageSourceIsLocalStorage(mirror)) {
>          virReportError(VIR_ERR_ARGUMENT_UNSUPPORTED, "%s",
>                         _("non-file destination not supported yet"));
> +        goto endjob;
>      }
>      if (stat(mirror->path, &st) < 0) {
>          if (errno != ENOENT) {
> -- 
> 2.1.0
> 
> --
> libvir-list mailing list
> libvir-list at redhat.com
> https://www.redhat.com/mailman/listinfo/libvir-list
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20150327/5c2a25d2/attachment-0001.sig>