[libvirt] [PATCH v2 0/7] Cleanup flags checking and fix setvcpus

Pavel Hrdina phrdina at redhat.com
Fri Mar 27 10:01:21 UTC 2015


The first four patches only cleanup the flags checking in our APIs by
introducing new macros to check exclusive flags and requirements.

Patch 5/7 uses the new macros to do better flags checking for
virDomainSetvcpusFlags API.

Patch 6/7 introduces macro to check virsh options requirements.

The last patch uses the requirement macro to cleanup virsh setvcpus code
and fixes a bug with --maximum option.

Because only the last patch actually fixes a bug issue, I'm not sure whether
this patch series should wait for next release cycle.

Luyao Huang (1):
  tools: fix the wrong check when use virsh setvcpus --maximum

Pavel Hrdina (6):
  internal: introduce macro helpers to reject exclusive flags
  internal: introduce macro helpers to check flag requirements
  use new macro helpers to check exclusive flags
  use new macro helpers to check flag requirements
  qemu: use new macros for setvcpus to check flags and cleanup the code
  virsh: introduce new macros to help check flag requirements

 src/internal.h                     |  87 +++++++++++
 src/libvirt-domain-snapshot.c      |  56 +++-----
 src/libvirt-domain.c               | 286 +++++++++++--------------------------
 src/qemu/qemu_driver.c             |  33 +----
 src/storage/storage_backend_disk.c |  10 +-
 src/storage/storage_backend_fs.c   |  11 +-
 tools/virsh-domain.c               |  30 +---
 tools/virsh.h                      |  52 +++++++
 8 files changed, 256 insertions(+), 309 deletions(-)

-- 
2.0.5




More information about the libvir-list mailing list