[libvirt] [PATCH 2/1] vircgroup: Fix build issue mingw cross compile

Eric Blake eblake at redhat.com
Fri Mar 27 22:05:59 UTC 2015


On 03/27/2015 10:41 AM, John Ferlan wrote:
> Commit id '2dbfa716' exposed virCgroupDetectMountsFromFile, but did not
> add the corresponding entry in the "#else /* !VIR_CGROUP_SUPPORTED */"
> section of the module.
> 
> Signed-off-by: John Ferlan <jferlan at redhat.com>
> ---
>  src/util/vircgroup.c | 11 +++++++++++
>  1 file changed, 11 insertions(+)

ACK for helping the issue. These two patches together fixed the build
for me.  Okay to leave them as separate patches, since they fix problems
introduced by different commits (and therefore might be backported at
different times).

But with this fixed, another build issue surfaces:

../../tools/virsh-domain-monitor.c: In function 'cmdDomIfAddr':
../../tools/virsh-domain-monitor.c:2233:17: error: expected identifier
or '(' before 'struct'
     const char *interface = NULL;
                 ^

'interface' is one of those black-listed terms that we should never use
in our code (because mingw headers pollute the namespace); we use
'iface' elsewhere.  We should really add a syntax check to avoid
re-introducing it all the time...


-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 604 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20150327/acbd9b3a/attachment-0001.sig>


More information about the libvir-list mailing list