[libvirt] [PATCH] Strip control codes in virBufferEscapeString

Pavel Hrdina phrdina at redhat.com
Mon Mar 30 12:55:14 UTC 2015


On Mon, Mar 30, 2015 at 01:02:49PM +0200, Ján Tomko wrote:
> These cannot be represented in XML.
> 
> We have been stripping them, but only if the string had
> characters that needed escaping: <>"'&
> 
> Extend the strcspn check to include control codes, and strip
> them even if we don't do any escaping.
> 
> https://bugzilla.redhat.com/show_bug.cgi?id=1184131
> https://bugzilla.redhat.com/show_bug.cgi?id=1066564
> ---
>  src/util/virbuffer.c | 14 +++++++++++---
>  tests/virbuftest.c   | 49 +++++++++++++++++++++++++++++++++++++++++++++++++
>  2 files changed, 60 insertions(+), 3 deletions(-)
> 

ACK, according to XML documentation characters below 0x20 except 0x09, 0x0A and
0x0D are forbidden.

Pavel




More information about the libvir-list mailing list