[libvirt] [PATCH] qemu: blockCopy: Pass adjusted bandwidth when called via blockRebase
Eric Blake
eblake at redhat.com
Mon Mar 30 16:54:14 UTC 2015
On 03/30/2015 09:41 AM, Peter Krempa wrote:
> The block copy API takes the speed in bytes/s rather than MiB/s that was
> the prior approach in virDomainBlockRebase. We correctly converted the
> speed to bytes/s in the old API but we still called the common helper
> virDomainBlockCopyCommon with the unadjusted variable.
>
> Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1207122
> ---
> src/qemu/qemu_driver.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
D'oh on my part. Probably snuck in while I was rebasing across several
different attempts for the best normalization approach.
ACK.
>
> diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c
> index 4d05221..6700fc9 100644
> --- a/src/qemu/qemu_driver.c
> +++ b/src/qemu/qemu_driver.c
> @@ -16811,7 +16811,7 @@ qemuDomainBlockRebase(virDomainPtr dom, const char *path, const char *base,
> flags &= (VIR_DOMAIN_BLOCK_REBASE_SHALLOW |
> VIR_DOMAIN_BLOCK_REBASE_REUSE_EXT);
> ret = qemuDomainBlockCopyCommon(vm, dom->conn, path, dest,
> - bandwidth, 0, 0, flags, true);
> + speed, 0, 0, flags, true);
> dest = NULL;
>
> cleanup:
>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 604 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20150330/54392cb1/attachment-0001.sig>
More information about the libvir-list
mailing list