[libvirt] [PATCH 2/2] conf: Rename virDomainHasDiskMirror and detect block jobs properly

Eric Blake eblake at redhat.com
Mon Mar 30 20:33:09 UTC 2015


On 03/30/2015 12:50 PM, Peter Krempa wrote:
> From: Shanzhi Yu <shyu at redhat.com>
> 
> virDomainHasDiskMirror() currently detects only jobs that add the mirror
> elements. Since some operations like migration are interlocked by
> existing block jobs on the given domain the check needs to be
> instrumented to check regular jobs too.
> 
> This patch renames virDomainHasDiskMirror to virDomainHasDiskBlockjob
> and adds an argument that allows to select that it returns true only for
> block copy jobs as those interlock making the domain persistent.
> 
> Other two uses trigger on any block job type.
> 
> Signed-off-by: Shanzhi Yu <shyu at redhat.com>
> Signed-off-by: Peter Krempa <pkrempa at redhat.com>
> ---
>  src/conf/domain_conf.c    | 25 ++++++++++++++++++++-----
>  src/conf/domain_conf.h    |  3 ++-
>  src/libvirt_private.syms  |  2 +-
>  src/qemu/qemu_driver.c    |  6 +++---
>  src/qemu/qemu_migration.c |  2 +-
>  5 files changed, 27 insertions(+), 11 deletions(-)

ACK; series should be safe for freeze as a bug fix.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 604 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20150330/645e9f8e/attachment-0001.sig>


More information about the libvir-list mailing list