[libvirt] [PATCH 1/3] qemu: processBlockJob: Don't unlock @vm twice

Eric Blake eblake at redhat.com
Mon Mar 30 20:39:00 UTC 2015


On 03/30/2015 03:26 AM, Peter Krempa wrote:
> Commit 1a92c719 moved code to handle block job events to a different
> function that is executed in a separate thread. The caller of
> processBlockJob handles locking and unlocking of @vm, so the we should
> not do it in the function itself.
> ---
>  src/qemu/qemu_driver.c | 1 -
>  1 file changed, 1 deletion(-)

ACK; bug fix so safe for freeze.

> 
> diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c
> index f07e4fb..f1cbc46 100644
> --- a/src/qemu/qemu_driver.c
> +++ b/src/qemu/qemu_driver.c
> @@ -4574,7 +4574,6 @@ processBlockJobEvent(virQEMUDriverPtr driver,
>              VIR_WARN("Unable to update persistent definition on vm %s "
>                       "after block job", vm->def->name);
>      }
> -    virObjectUnlock(vm);
>      virObjectUnref(cfg);
> 
>      if (event)
> 

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 604 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20150330/9fd19921/attachment-0001.sig>


More information about the libvir-list mailing list